Initial commit: Odoo 18.0-20251222 extra-addons

sale_order_general_discount/README.rst

@@ -0,0 +1,107 @@
+===========================
+Sale Order General Discount
+===========================
+
+.. 
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! source digest: sha256:dc305f87242dab2460692c690e2518c4e909517be6ecca4bda17b156ba03b181
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Production%2FStable-green.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Production/Stable
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+    :alt: License: AGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github
+    :target: https://github.com/OCA/sale-workflow/tree/18.0/sale_order_general_discount
+    :alt: OCA/sale-workflow
+.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
+    :target: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_order_general_discount
+    :alt: Translate me on Weblate
+.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&target_branch=18.0
+    :alt: Try me on Runboat
+
+|badge1| |badge2| |badge3| |badge4| |badge5|
+
+This module allows to set a general discount in a sales order. This
+general discount is set to each line order in the standard discount
+field.
+
+You can configure:
+
+- a default general discount on customers
+- On each product define if general discount is applied
+
+**Table of contents**
+
+.. contents::
+   :local:
+
+Installation
+============
+
+You need to install sale_management module for accessing the needed
+menus.
+
+Usage
+=====
+
+To use this module, you need to:
+
+1. Create a sale order and set a discount, this discount will be set in
+   all lines.
+2. You can set a discount in a partner.
+3. On product you can define if you apply general discount on sale order
+   line linked to that product
+
+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/sale-workflow/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us to smash it by providing a detailed and welcomed
+`feedback <https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_order_general_discount%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+
+Do not contact contributors directly about support or help with technical issues.
+
+Credits
+=======
+
+Authors
+-------
+
+* Tecnativa
+
+Contributors
+------------
+
+- `Tecnativa <https://www.tecnativa.com>`__:
+
+  - Sergio Teruel <sergio.teruel@tecnativa.com>
+  - Stefan Ungureanu <stefan.ungureanu@tecnativa.com>
+
+- Raf Ven <raf.ven@dynapps.be>
+- Sudhir Arya <sudhir@erpharbor.com>
+- Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>
+
+Maintainers
+-----------
+
+This module is maintained by the OCA.
+
+.. image:: https://odoo-community.org/logo.png
+   :alt: Odoo Community Association
+   :target: https://odoo-community.org
+
+OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.
+
+This module is part of the `OCA/sale-workflow <https://github.com/OCA/sale-workflow/tree/18.0/sale_order_general_discount>`_ project on GitHub.
+
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

sale_order_general_discount/__init__.py

@@ -0,0 +1,3 @@
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+from . import models

sale_order_general_discount/__manifest__.py

@@ -0,0 +1,20 @@
+# Copyright 2018 Tecnativa - Sergio Teruel
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+{
+    "name": "Sale Order General Discount",
+    "summary": "General discount per sale order",
+    "version": "18.0.1.0.0",
+    "development_status": "Production/Stable",
+    "category": "Sales",
+    "website": "https://github.com/OCA/sale-workflow",
+    "author": "Tecnativa, Odoo Community Association (OCA)",
+    "license": "AGPL-3",
+    "application": False,
+    "installable": True,
+    "depends": ["sale"],
+    "data": [
+        "views/product_view.xml",
+        "views/sale_order_view.xml",
+        "views/res_partner_view.xml",
+    ],
+}

sale_order_general_discount/i18n/de.po

@@ -0,0 +1,46 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+# 	* sale_order_general_discount
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 12.0\n"
+"Report-Msgid-Bugs-To: \n"
+"PO-Revision-Date: 2019-07-15 13:43+0000\n"
+"Last-Translator: Maria Sparenberg <maria.sparenberg@gmx.net>\n"
+"Language-Team: none\n"
+"Language: de\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: nplurals=2; plural=n != 1;\n"
+"X-Generator: Weblate 3.7.1\n"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_res_partner
+msgid "Contact"
+msgstr "Kontakt"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_partner__sale_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_users__sale_discount
+#, fuzzy
+msgid "Discount"
+msgstr "Rabatt (%)"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_sale_order__general_discount
+msgid "Discount (%)"
+msgstr "Rabatt (%)"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order
+#, fuzzy
+msgid "Sales Order"
+msgstr "Verkaufsauftrag"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order_line
+#, fuzzy
+msgid "Sales Order Line"
+msgstr "Verkaufsauftrag"

sale_order_general_discount/i18n/es.po

@@ -0,0 +1,47 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+# 	* sale_order_general_discount
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 11.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2018-07-31 09:08+0200\n"
+"PO-Revision-Date: 2020-10-26 12:08+0000\n"
+"Last-Translator: Daniel Martinez Vila <daniel.martinez@qubiq.es>\n"
+"Language-Team: \n"
+"Language: es\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=2; plural=n != 1;\n"
+"X-Generator: Weblate 3.10\n"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_res_partner
+msgid "Contact"
+msgstr "Contacto"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_partner__sale_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_users__sale_discount
+msgid "Discount"
+msgstr "Descuento"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_sale_order__general_discount
+msgid "Discount (%)"
+msgstr "Descuento (%)"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order
+msgid "Sales Order"
+msgstr "Pedido de venta"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order_line
+msgid "Sales Order Line"
+msgstr "Línea Pedido de Venta"
+
+#~ msgid "Quotation"
+#~ msgstr "Presupuesto"

sale_order_general_discount/i18n/it.po

@@ -0,0 +1,43 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+# 	* sale_order_general_discount
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 12.0\n"
+"Report-Msgid-Bugs-To: \n"
+"PO-Revision-Date: 2022-04-08 17:05+0000\n"
+"Last-Translator: Francesco Foresti <francesco.foresti@ooops404.com>\n"
+"Language-Team: none\n"
+"Language: it\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: nplurals=2; plural=n != 1;\n"
+"X-Generator: Weblate 4.3.2\n"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_res_partner
+msgid "Contact"
+msgstr "Contatto"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_partner__sale_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_users__sale_discount
+msgid "Discount"
+msgstr "Sconto"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_sale_order__general_discount
+msgid "Discount (%)"
+msgstr "Sconto (%)"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order
+msgid "Sales Order"
+msgstr "Ordine di vendita"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order_line
+msgid "Sales Order Line"
+msgstr "Riga ordine di vendita"

sale_order_general_discount/i18n/pt_BR.po

@@ -0,0 +1,43 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+# 	* sale_order_general_discount
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 16.0\n"
+"Report-Msgid-Bugs-To: \n"
+"PO-Revision-Date: 2023-10-12 13:38+0000\n"
+"Last-Translator: Adriano Prado <adrianojprado@gmail.com>\n"
+"Language-Team: none\n"
+"Language: pt_BR\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: nplurals=2; plural=n > 1;\n"
+"X-Generator: Weblate 4.17\n"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_res_partner
+msgid "Contact"
+msgstr "Contato"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_partner__sale_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_users__sale_discount
+msgid "Discount"
+msgstr "Desconto"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_sale_order__general_discount
+msgid "Discount (%)"
+msgstr "Desconto (%)"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order
+msgid "Sales Order"
+msgstr "Pedido de Venda"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order_line
+msgid "Sales Order Line"
+msgstr "Item Pedido de Venda"

sale_order_general_discount/i18n/sale_order_general_discount.pot

@@ -0,0 +1,81 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+# 	* sale_order_general_discount
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 18.0\n"
+"Report-Msgid-Bugs-To: \n"
+"Last-Translator: \n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_product_product__bypass_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_product_template__bypass_general_discount
+msgid "Bypass General Discount"
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_res_partner
+msgid "Contact"
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model_terms:ir.ui.view,arch_db:sale_order_general_discount.view_partner_form
+msgid "Discount"
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_sale_order_line__discount
+#: model_terms:ir.ui.view,arch_db:sale_order_general_discount.sale_order_general_discount_form_view
+msgid "Discount (%)"
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model_terms:ir.ui.view,arch_db:sale_order_general_discount.product_normal_form_view
+#: model_terms:ir.ui.view,arch_db:sale_order_general_discount.product_template_only_form_view
+msgid "Don't apply general discount"
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_sale_order__general_discount
+msgid "General Discount"
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,help:sale_order_general_discount.field_product_product__bypass_general_discount
+#: model:ir.model.fields,help:sale_order_general_discount.field_product_template__bypass_general_discount
+msgid ""
+"If this checkbox is not ticked, it means changing general discount on sale "
+"order will impact sale order lines with this related product."
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_product_template
+msgid "Product"
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_product_product
+msgid "Product Variant"
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_partner__sale_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_users__sale_discount
+msgid "Sale Discount"
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order
+msgid "Sales Order"
+msgstr ""
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order_line
+msgid "Sales Order Line"
+msgstr ""

sale_order_general_discount/i18n/zh_CN.po

@@ -0,0 +1,46 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+# 	* sale_order_general_discount
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 12.0\n"
+"Report-Msgid-Bugs-To: \n"
+"PO-Revision-Date: 2019-09-01 11:23+0000\n"
+"Last-Translator: 黎伟杰 <674416404@qq.com>\n"
+"Language-Team: none\n"
+"Language: zh_CN\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: nplurals=1; plural=0;\n"
+"X-Generator: Weblate 3.8\n"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_res_partner
+msgid "Contact"
+msgstr "联系人"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_partner__sale_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_res_users__sale_discount
+#, fuzzy
+msgid "Discount"
+msgstr "折扣(%)"
+
+#. module: sale_order_general_discount
+#: model:ir.model.fields,field_description:sale_order_general_discount.field_sale_order__general_discount
+msgid "Discount (%)"
+msgstr "折扣(%)"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order
+#, fuzzy
+msgid "Sales Order"
+msgstr "销售订单"
+
+#. module: sale_order_general_discount
+#: model:ir.model,name:sale_order_general_discount.model_sale_order_line
+#, fuzzy
+msgid "Sales Order Line"
+msgstr "销售订单"

sale_order_general_discount/models/__init__.py

@@ -0,0 +1,6 @@
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from . import product_product
+from . import product_template
+from . import res_partner
+from . import sale_order
+from . import sale_order_line

sale_order_general_discount/models/product_product.py

@@ -0,0 +1,12 @@
+# Copyright 2021 - Pierre Verkest
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from odoo import fields, models
+
+
+class ProductProduct(models.Model):
+    _inherit = "product.product"
+
+    bypass_general_discount = fields.Boolean(
+        help="If this checkbox is not ticked, it means changing general discount on "
+        "sale order will impact sale order lines with this related product.",
+    )

sale_order_general_discount/models/product_template.py

@@ -0,0 +1,36 @@
+# Copyright 2021 - Pierre Verkest
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from odoo import api, fields, models
+
+
+class ProductTemplate(models.Model):
+    _inherit = "product.template"
+
+    bypass_general_discount = fields.Boolean(
+        compute="_compute_bypass_general_discount",
+        inverse="_inverse_bypass_general_discount",
+        search="_search_bypass_general_discount",
+        help="If this checkbox is not ticked, it means changing general discount on "
+        "sale order will impact sale order lines with this related product.",
+    )
+
+    def _search_bypass_general_discount(self, operator, value):
+        templates = self.with_context(active_test=False).search(
+            [("product_variant_ids.bypass_general_discount", operator, value)]
+        )
+        return [("id", "in", templates.ids)]
+
+    @api.depends("product_variant_ids.bypass_general_discount")
+    def _compute_bypass_general_discount(self):
+        self.bypass_general_discount = False
+        for template in self:
+            if len(template.product_variant_ids) == 1:
+                template.bypass_general_discount = (
+                    template.product_variant_ids.bypass_general_discount
+                )
+
+    def _inverse_bypass_general_discount(self):
+        if len(self.product_variant_ids) == 1:
+            self.product_variant_ids.bypass_general_discount = (
+                self.bypass_general_discount
+            )

sale_order_general_discount/models/res_partner.py

@@ -0,0 +1,17 @@
+# Copyright 2018 Tecnativa - Sergio Teruel
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+from odoo import api, fields, models
+
+
+class ResPartner(models.Model):
+    _inherit = "res.partner"
+
+    sale_discount = fields.Float(
+        digits="Discount",
+        company_dependent=True,
+    )
+
+    @api.model
+    def _commercial_fields(self):
+        return super()._commercial_fields() + ["sale_discount"]

sale_order_general_discount/models/sale_order.py

@@ -0,0 +1,44 @@
+# Copyright 2018 Tecnativa - Sergio Teruel
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from lxml import etree
+
+from odoo import api, fields, models
+
+
+class SaleOrder(models.Model):
+    _inherit = "sale.order"
+
+    general_discount = fields.Float(
+        compute="_compute_general_discount",
+        store=True,
+        readonly=False,
+        digits="Discount",
+    )
+
+    @api.depends("partner_id")
+    def _compute_general_discount(self):
+        for so in self:
+            so.general_discount = so.partner_id.sale_discount
+
+    @api.model
+    def get_view(self, view_id=None, view_type="form", **options):
+        """The purpose of this is to write a context on "order_line" field
+        respecting other contexts on this field.
+        There is a PR (https://github.com/odoo/odoo/pull/26607) to odoo for
+        avoiding this. If merged, remove this method and add the attribute
+        in the field.
+        """
+        res = super().get_view(view_id=view_id, view_type=view_type, **options)
+        if view_type == "form":
+            order_xml = etree.XML(res["arch"])
+            order_line_fields = order_xml.xpath("//field[@name='order_line']")
+            if order_line_fields:
+                order_line_field = order_line_fields[0]
+                context = order_line_field.attrib.get("context", "{}").replace(
+                    "{",
+                    "{'default_discount': general_discount, ",
+                    1,
+                )
+                order_line_field.attrib["context"] = context
+                res["arch"] = etree.tostring(order_xml)
+        return res

sale_order_general_discount/models/sale_order_line.py

@@ -0,0 +1,29 @@
+# Copyright 2018 Tecnativa - Sergio Teruel
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from odoo import api, fields, models
+
+
+class SaleOrderLine(models.Model):
+    _inherit = "sale.order.line"
+
+    discount = fields.Float(
+        compute="_compute_discount",
+        store=True,
+        readonly=False,
+    )
+
+    @api.depends("order_id", "order_id.general_discount")
+    def _compute_discount(self):
+        res = super()._compute_discount()
+        for line in self:
+            # We check the value of general_discount on origin too to cover
+            # the case where a discount was set to a value != 0 and then
+            # set again to 0 to remove the discount on all the lines at the same
+            # time
+            if not line.product_id.bypass_general_discount and (
+                line.order_id.general_discount or line.order_id._origin.general_discount
+            ):
+                line.discount = line.order_id.general_discount
+            else:
+                line.discount = 0
+        return res

sale_order_general_discount/pyproject.toml

@@ -0,0 +1,3 @@
+[build-system]
+requires = ["whool"]
+build-backend = "whool.buildapi"

sale_order_general_discount/readme/CONTRIBUTORS.md

@@ -0,0 +1,6 @@
+- [Tecnativa](https://www.tecnativa.com):
+  - Sergio Teruel \<<sergio.teruel@tecnativa.com>\>
+  - Stefan Ungureanu \<<stefan.ungureanu@tecnativa.com>\>
+- Raf Ven \<<raf.ven@dynapps.be>\>
+- Sudhir Arya \<<sudhir@erpharbor.com>\>
+- Heliconia Solutions Pvt. Ltd. \<<https://www.heliconia.io>\>

sale_order_general_discount/readme/DESCRIPTION.md

@@ -0,0 +1,7 @@
+This module allows to set a general discount in a sales order. This
+general discount is set to each line order in the standard discount
+field.
+
+You can configure:  
+- a default general discount on customers
+- On each product define if general discount is applied

sale_order_general_discount/readme/INSTALL.md

@@ -0,0 +1,2 @@
+You need to install sale_management module for accessing the needed
+menus.

sale_order_general_discount/readme/USAGE.md

@@ -0,0 +1,7 @@
+To use this module, you need to:
+
+1.  Create a sale order and set a discount, this discount will be set in
+    all lines.
+2.  You can set a discount in a partner.
+3.  On product you can define if you apply general discount on sale
+    order line linked to that product

sale_order_general_discount/static/description/index.html

@@ -0,0 +1,455 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
+<head>
+<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
+<meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
+<title>Sale Order General Discount</title>
+<style type="text/css">
+
+/*
+:Author: David Goodger (goodger@python.org)
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
+:Copyright: This stylesheet has been placed in the public domain.
+
+Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
+
+See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
+customize this style sheet.
+*/
+
+/* used to remove borders from tables and images */
+.borderless, table.borderless td, table.borderless th {
+  border: 0 }
+
+table.borderless td, table.borderless th {
+  /* Override padding for "table.docutils td" with "! important".
+     The right padding separates the table cells. */
+  padding: 0 0.5em 0 0 ! important }
+
+.first {
+  /* Override more specific margin styles with "! important". */
+  margin-top: 0 ! important }
+
+.last, .with-subtitle {
+  margin-bottom: 0 ! important }
+
+.hidden {
+  display: none }
+
+.subscript {
+  vertical-align: sub;
+  font-size: smaller }
+
+.superscript {
+  vertical-align: super;
+  font-size: smaller }
+
+a.toc-backref {
+  text-decoration: none ;
+  color: black }
+
+blockquote.epigraph {
+  margin: 2em 5em ; }
+
+dl.docutils dd {
+  margin-bottom: 0.5em }
+
+object[type="image/svg+xml"], object[type="application/x-shockwave-flash"] {
+  overflow: hidden;
+}
+
+/* Uncomment (and remove this text!) to get bold-faced definition list terms
+dl.docutils dt {
+  font-weight: bold }
+*/
+
+div.abstract {
+  margin: 2em 5em }
+
+div.abstract p.topic-title {
+  font-weight: bold ;
+  text-align: center }
+
+div.admonition, div.attention, div.caution, div.danger, div.error,
+div.hint, div.important, div.note, div.tip, div.warning {
+  margin: 2em ;
+  border: medium outset ;
+  padding: 1em }
+
+div.admonition p.admonition-title, div.hint p.admonition-title,
+div.important p.admonition-title, div.note p.admonition-title,
+div.tip p.admonition-title {
+  font-weight: bold ;
+  font-family: sans-serif }
+
+div.attention p.admonition-title, div.caution p.admonition-title,
+div.danger p.admonition-title, div.error p.admonition-title,
+div.warning p.admonition-title, .code .error {
+  color: red ;
+  font-weight: bold ;
+  font-family: sans-serif }
+
+/* Uncomment (and remove this text!) to get reduced vertical space in
+   compound paragraphs.
+div.compound .compound-first, div.compound .compound-middle {
+  margin-bottom: 0.5em }
+
+div.compound .compound-last, div.compound .compound-middle {
+  margin-top: 0.5em }
+*/
+
+div.dedication {
+  margin: 2em 5em ;
+  text-align: center ;
+  font-style: italic }
+
+div.dedication p.topic-title {
+  font-weight: bold ;
+  font-style: normal }
+
+div.figure {
+  margin-left: 2em ;
+  margin-right: 2em }
+
+div.footer, div.header {
+  clear: both;
+  font-size: smaller }
+
+div.line-block {
+  display: block ;
+  margin-top: 1em ;
+  margin-bottom: 1em }
+
+div.line-block div.line-block {
+  margin-top: 0 ;
+  margin-bottom: 0 ;
+  margin-left: 1.5em }
+
+div.sidebar {
+  margin: 0 0 0.5em 1em ;
+  border: medium outset ;
+  padding: 1em ;
+  background-color: #ffffee ;
+  width: 40% ;
+  float: right ;
+  clear: right }
+
+div.sidebar p.rubric {
+  font-family: sans-serif ;
+  font-size: medium }
+
+div.system-messages {
+  margin: 5em }
+
+div.system-messages h1 {
+  color: red }
+
+div.system-message {
+  border: medium outset ;
+  padding: 1em }
+
+div.system-message p.system-message-title {
+  color: red ;
+  font-weight: bold }
+
+div.topic {
+  margin: 2em }
+
+h1.section-subtitle, h2.section-subtitle, h3.section-subtitle,
+h4.section-subtitle, h5.section-subtitle, h6.section-subtitle {
+  margin-top: 0.4em }
+
+h1.title {
+  text-align: center }
+
+h2.subtitle {
+  text-align: center }
+
+hr.docutils {
+  width: 75% }
+
+img.align-left, .figure.align-left, object.align-left, table.align-left {
+  clear: left ;
+  float: left ;
+  margin-right: 1em }
+
+img.align-right, .figure.align-right, object.align-right, table.align-right {
+  clear: right ;
+  float: right ;
+  margin-left: 1em }
+
+img.align-center, .figure.align-center, object.align-center {
+  display: block;
+  margin-left: auto;
+  margin-right: auto;
+}
+
+table.align-center {
+  margin-left: auto;
+  margin-right: auto;
+}
+
+.align-left {
+  text-align: left }
+
+.align-center {
+  clear: both ;
+  text-align: center }
+
+.align-right {
+  text-align: right }
+
+/* reset inner alignment in figures */
+div.align-right {
+  text-align: inherit }
+
+/* div.align-center * { */
+/*   text-align: left } */
+
+.align-top    {
+  vertical-align: top }
+
+.align-middle {
+  vertical-align: middle }
+
+.align-bottom {
+  vertical-align: bottom }
+
+ol.simple, ul.simple {
+  margin-bottom: 1em }
+
+ol.arabic {
+  list-style: decimal }
+
+ol.loweralpha {
+  list-style: lower-alpha }
+
+ol.upperalpha {
+  list-style: upper-alpha }
+
+ol.lowerroman {
+  list-style: lower-roman }
+
+ol.upperroman {
+  list-style: upper-roman }
+
+p.attribution {
+  text-align: right ;
+  margin-left: 50% }
+
+p.caption {
+  font-style: italic }
+
+p.credits {
+  font-style: italic ;
+  font-size: smaller }
+
+p.label {
+  white-space: nowrap }
+
+p.rubric {
+  font-weight: bold ;
+  font-size: larger ;
+  color: maroon ;
+  text-align: center }
+
+p.sidebar-title {
+  font-family: sans-serif ;
+  font-weight: bold ;
+  font-size: larger }
+
+p.sidebar-subtitle {
+  font-family: sans-serif ;
+  font-weight: bold }
+
+p.topic-title {
+  font-weight: bold }
+
+pre.address {
+  margin-bottom: 0 ;
+  margin-top: 0 ;
+  font: inherit }
+
+pre.literal-block, pre.doctest-block, pre.math, pre.code {
+  margin-left: 2em ;
+  margin-right: 2em }
+
+pre.code .ln { color: gray; } /* line numbers */
+pre.code, code { background-color: #eeeeee }
+pre.code .comment, code .comment { color: #5C6576 }
+pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
+pre.code .literal.string, code .literal.string { color: #0C5404 }
+pre.code .name.builtin, code .name.builtin { color: #352B84 }
+pre.code .deleted, code .deleted { background-color: #DEB0A1}
+pre.code .inserted, code .inserted { background-color: #A3D289}
+
+span.classifier {
+  font-family: sans-serif ;
+  font-style: oblique }
+
+span.classifier-delimiter {
+  font-family: sans-serif ;
+  font-weight: bold }
+
+span.interpreted {
+  font-family: sans-serif }
+
+span.option {
+  white-space: nowrap }
+
+span.pre {
+  white-space: pre }
+
+span.problematic, pre.problematic {
+  color: red }
+
+span.section-subtitle {
+  /* font-size relative to parent (h1..h6 element) */
+  font-size: 80% }
+
+table.citation {
+  border-left: solid 1px gray;
+  margin-left: 1px }
+
+table.docinfo {
+  margin: 2em 4em }
+
+table.docutils {
+  margin-top: 0.5em ;
+  margin-bottom: 0.5em }
+
+table.footnote {
+  border-left: solid 1px black;
+  margin-left: 1px }
+
+table.docutils td, table.docutils th,
+table.docinfo td, table.docinfo th {
+  padding-left: 0.5em ;
+  padding-right: 0.5em ;
+  vertical-align: top }
+
+table.docutils th.field-name, table.docinfo th.docinfo-name {
+  font-weight: bold ;
+  text-align: left ;
+  white-space: nowrap ;
+  padding-left: 0 }
+
+/* "booktabs" style (no vertical lines) */
+table.docutils.booktabs {
+  border: 0px;
+  border-top: 2px solid;
+  border-bottom: 2px solid;
+  border-collapse: collapse;
+}
+table.docutils.booktabs * {
+  border: 0px;
+}
+table.docutils.booktabs th {
+  border-bottom: thin solid;
+  text-align: left;
+}
+
+h1 tt.docutils, h2 tt.docutils, h3 tt.docutils,
+h4 tt.docutils, h5 tt.docutils, h6 tt.docutils {
+  font-size: 100% }
+
+ul.auto-toc {
+  list-style-type: none }
+
+</style>
+</head>
+<body>
+<div class="document" id="sale-order-general-discount">
+<h1 class="title">Sale Order General Discount</h1>
+
+<!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+!! This file is generated by oca-gen-addon-readme !!
+!! changes will be overwritten.                   !!
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+!! source digest: sha256:dc305f87242dab2460692c690e2518c4e909517be6ecca4bda17b156ba03b181
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/sale-workflow/tree/18.0/sale_order_general_discount"><img alt="OCA/sale-workflow" src="https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_order_general_discount"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p>This module allows to set a general discount in a sales order. This
+general discount is set to each line order in the standard discount
+field.</p>
+<p>You can configure:</p>
+<ul class="simple">
+<li>a default general discount on customers</li>
+<li>On each product define if general discount is applied</li>
+</ul>
+<p><strong>Table of contents</strong></p>
+<div class="contents local topic" id="contents">
+<ul class="simple">
+<li><a class="reference internal" href="#installation" id="toc-entry-1">Installation</a></li>
+<li><a class="reference internal" href="#usage" id="toc-entry-2">Usage</a></li>
+<li><a class="reference internal" href="#bug-tracker" id="toc-entry-3">Bug Tracker</a></li>
+<li><a class="reference internal" href="#credits" id="toc-entry-4">Credits</a><ul>
+<li><a class="reference internal" href="#authors" id="toc-entry-5">Authors</a></li>
+<li><a class="reference internal" href="#contributors" id="toc-entry-6">Contributors</a></li>
+<li><a class="reference internal" href="#maintainers" id="toc-entry-7">Maintainers</a></li>
+</ul>
+</li>
+</ul>
+</div>
+<div class="section" id="installation">
+<h1><a class="toc-backref" href="#toc-entry-1">Installation</a></h1>
+<p>You need to install sale_management module for accessing the needed
+menus.</p>
+</div>
+<div class="section" id="usage">
+<h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
+<p>To use this module, you need to:</p>
+<ol class="arabic simple">
+<li>Create a sale order and set a discount, this discount will be set in
+all lines.</li>
+<li>You can set a discount in a partner.</li>
+<li>On product you can define if you apply general discount on sale order
+line linked to that product</li>
+</ol>
+</div>
+<div class="section" id="bug-tracker">
+<h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
+<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/sale-workflow/issues">GitHub Issues</a>.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us to smash it by providing a detailed and welcomed
+<a class="reference external" href="https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_order_general_discount%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<p>Do not contact contributors directly about support or help with technical issues.</p>
+</div>
+<div class="section" id="credits">
+<h1><a class="toc-backref" href="#toc-entry-4">Credits</a></h1>
+<div class="section" id="authors">
+<h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
+<ul class="simple">
+<li>Tecnativa</li>
+</ul>
+</div>
+<div class="section" id="contributors">
+<h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
+<ul class="simple">
+<li><a class="reference external" href="https://www.tecnativa.com">Tecnativa</a>:<ul>
+<li>Sergio Teruel &lt;<a class="reference external" href="mailto:sergio.teruel&#64;tecnativa.com">sergio.teruel&#64;tecnativa.com</a>&gt;</li>
+<li>Stefan Ungureanu &lt;<a class="reference external" href="mailto:stefan.ungureanu&#64;tecnativa.com">stefan.ungureanu&#64;tecnativa.com</a>&gt;</li>
+</ul>
+</li>
+<li>Raf Ven &lt;<a class="reference external" href="mailto:raf.ven&#64;dynapps.be">raf.ven&#64;dynapps.be</a>&gt;</li>
+<li>Sudhir Arya &lt;<a class="reference external" href="mailto:sudhir&#64;erpharbor.com">sudhir&#64;erpharbor.com</a>&gt;</li>
+<li>Heliconia Solutions Pvt. Ltd. &lt;<a class="reference external" href="https://www.heliconia.io">https://www.heliconia.io</a>&gt;</li>
+</ul>
+</div>
+<div class="section" id="maintainers">
+<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
+<p>This module is maintained by the OCA.</p>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
+<p>OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/sale-workflow/tree/18.0/sale_order_general_discount">OCA/sale-workflow</a> project on GitHub.</p>
+<p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
+</div>
+</div>
+</div>
+</body>
+</html>

sale_order_general_discount/tests/__init__.py

@@ -0,0 +1,3 @@
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+from . import test_sale_order_general_discount

sale_order_general_discount/tests/test_sale_order_general_discount.py

@@ -0,0 +1,182 @@
+# Copyright 2018 Tecnativa - Sergio Teruel
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from lxml import etree
+
+from odoo.tests import TransactionCase
+
+
+class TestSaleOrderLineInput(TransactionCase):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.partner = cls.env["res.partner"].create(
+            [{"name": "Test", "sale_discount": 10.0}]
+        )
+        cls.contact = cls.env["res.partner"].create(
+            [
+                {
+                    "name": "Contact Test",
+                    "parent_id": cls.partner.id,
+                    "type": "contact",
+                }
+            ]
+        )
+        cls.product = cls.env["product.product"].create(
+            [{"name": "test_product", "type": "service"}]
+        )
+        cls.pricelist = cls.env["product.pricelist"].create(
+            [{"name": "Public Pricelist", "sequence": 1}]
+        )
+        cls.product2 = cls.env["product.product"].create(
+            [
+                {
+                    "name": "test product without general discount",
+                    "type": "service",
+                    "bypass_general_discount": True,
+                }
+            ]
+        )
+        cls.order = cls.env["sale.order"].create(
+            [
+                {
+                    "partner_id": cls.partner.id,
+                    "order_line": [
+                        (
+                            0,
+                            0,
+                            {
+                                "name": cls.product.name,
+                                "product_id": cls.product.id,
+                                "product_uom_qty": 1,
+                                "product_uom": cls.product.uom_id.id,
+                                "price_unit": 1000.00,
+                            },
+                        ),
+                        (
+                            0,
+                            0,
+                            {
+                                "name": cls.product2.name,
+                                "product_id": cls.product2.id,
+                                "product_uom_qty": 1,
+                                "product_uom": cls.product2.uom_id.id,
+                                "price_unit": 1000.00,
+                            },
+                        ),
+                    ],
+                    "pricelist_id": cls.pricelist.id,
+                }
+            ]
+        )
+        cls.contact_order = cls.env["sale.order"].create(
+            [
+                {
+                    "partner_id": cls.contact.id,
+                    "order_line": [
+                        (
+                            0,
+                            0,
+                            {
+                                "name": cls.product.name,
+                                "product_id": cls.product.id,
+                                "product_uom_qty": 1,
+                                "product_uom": cls.product.uom_id.id,
+                                "price_unit": 1000.00,
+                            },
+                        )
+                    ],
+                    "pricelist_id": cls.pricelist.id,
+                }
+            ]
+        )
+        cls.View = cls.env["ir.ui.view"]
+
+    def test_default_partner_discount(self):
+        self.assertEqual(self.order.general_discount, self.partner.sale_discount)
+
+    def test_contact_partner_discount(self):
+        self.assertEqual(
+            self.contact_order.general_discount, self.partner.sale_discount
+        )
+
+    def test_sale_order_values(self):
+        self.order.general_discount = 10
+        self.assertEqual(self.order.order_line[0].price_subtotal, 900.00)
+        self.assertEqual(self.order.order_line[1].price_subtotal, 1000.00)
+
+    def _get_ctx_from_view(self, res):
+        order_xml = etree.XML(res["arch"])
+        order_line_path = "//field[@name='order_line']"
+        order_line_field = order_xml.xpath(order_line_path)[0]
+        return order_line_field.attrib.get("context", "{}")
+
+    def test_default_line_discount_value(self):
+        res = self.order.get_view(
+            view_id=self.env.ref(
+                "sale_order_general_discount." "sale_order_general_discount_form_view"
+            ).id,
+            view_type="form",
+        )
+        ctx = self._get_ctx_from_view(res)
+        self.assertTrue("default_discount" in ctx)
+        view = self.View.create(
+            [
+                {
+                    "name": "test",
+                    "type": "form",
+                    "model": "sale.order",
+                    "arch": """
+                <form>
+                    <field name='order_line'
+                        context="{'default_product_uom_qty': 3.0}">
+                    </field>
+                </form>
+            """,
+                }
+            ]
+        )
+        res = self.order.get_view(view_id=view.id, view_type="form")
+        ctx = self._get_ctx_from_view(res)
+        self.assertTrue("default_discount" in ctx)
+
+    def test_sale_order_line_wo_form_view(self):
+        self.order.general_discount = 10
+        vals = {
+            "name": self.product.name,
+            "product_id": self.product.id,
+            "product_uom_qty": 1,
+            "product_uom": self.product.uom_id.id,
+            "price_unit": 1000.00,
+            "order_id": self.order.id,
+        }
+        order_line = self.env["sale.order.line"].create(vals)
+        self.assertEqual(order_line.price_subtotal, 900.00)
+        self.assertEqual(order_line.discount, 10)
+        vals["discount"] = 20
+        order_line2 = self.env["sale.order.line"].create(vals)
+        self.assertEqual(order_line2.price_subtotal, 800.00)
+        self.assertEqual(order_line2.discount, 20)
+
+    def test_compute_discount(self):
+        self.order.general_discount = 10
+        self.assertEqual(self.order.order_line[0].discount, 10)
+        self.assertEqual(self.order.order_line[1].discount, 0)
+        self.order.order_line[0].discount = 1
+        self.order.order_line[1].discount = 2
+        self.order.order_line._compute_discount()
+        self.assertEqual(self.order.order_line[0].discount, 10)
+        self.assertEqual(self.order.order_line[1].discount, 0)
+
+    def test_product_template(self):
+        self.assertFalse(self.product.product_tmpl_id.bypass_general_discount)
+        self.assertTrue(self.product2.product_tmpl_id.bypass_general_discount)
+        self.product.product_tmpl_id.bypass_general_discount = True
+        self.assertTrue(self.product.bypass_general_discount)
+
+    def test_search_product_template_per_bypass_general_discount(self):
+        self.assertEqual(
+            self.env["product.template"]
+            .search([("bypass_general_discount", "=", True)])
+            .id,
+            self.product2.product_tmpl_id.id,
+        )

sale_order_general_discount/views/product_view.xml

@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <record id="product_normal_form_view" model="ir.ui.view">
+        <field name="name">sale_order_general_discount.product_normal_form_view</field>
+        <field name="model">product.product</field>
+        <field name="priority" eval="16" />
+        <field name="inherit_id" ref="product.product_normal_form_view" />
+        <field name="arch" type="xml">
+            <xpath expr="//group[@name='group_standard_price']" position="inside">
+                <field
+                    name="bypass_general_discount"
+                    string="Don't apply general discount"
+                />
+            </xpath>
+        </field>
+    </record>
+    <record id="product_template_only_form_view" model="ir.ui.view">
+        <field name="name">product.template.sale_order_general_discount.form</field>
+        <field name="model">product.template</field>
+        <field name="priority" eval="24" />
+        <field name="inherit_id" ref="product.product_template_only_form_view" />
+        <field name="arch" type="xml">
+            <xpath expr="//group[@name='group_standard_price']" position="inside">
+                <field
+                    name="bypass_general_discount"
+                    string="Don't apply general discount"
+                    invisible="product_variant_count > 1"
+                />
+            </xpath>
+        </field>
+    </record>
+</odoo>

sale_order_general_discount/views/res_partner_view.xml

@@ -0,0 +1,20 @@
+<?xml version="1.0" ?>
+<!-- Copyright 2018 Tecnativa - Sergio Teruel
+     License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
+<odoo>
+    <record id="view_partner_form" model="ir.ui.view">
+        <field name="model">res.partner</field>
+        <field name="inherit_id" ref="base.view_partner_form" />
+        <field name="arch" type="xml">
+            <xpath
+                expr="//page[@name='sales_purchases']//field[@name='user_id']"
+                position="after"
+            >
+                <label for="sale_discount" />
+                <div>
+                    <field name="sale_discount" string="Discount" class="oe_inline" /> %
+                </div>
+            </xpath>
+        </field>
+    </record>
+</odoo>

sale_order_general_discount/views/sale_order_view.xml

@@ -0,0 +1,23 @@
+<?xml version="1.0" ?>
+<!-- Copyright 2018 Tecnativa - Sergio Teruel
+     License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
+<odoo>
+    <record id="sale_order_general_discount_form_view" model="ir.ui.view">
+        <field name="name">sale.order.general.discount.form</field>
+        <field name="model">sale.order</field>
+        <field name="inherit_id" ref="sale.view_order_form" />
+        <field name="arch" type="xml">
+            <xpath expr="//field[@name='tax_totals']" position="before">
+                <div class="oe_row" style="float:right;">
+                    <label for="general_discount" />
+                    <field
+                        name="general_discount"
+                        style="width: 5.5rem;"
+                        class="oe_subtotal_footer_separator mr-0"
+                        string="Discount (%)"
+                    />
+                </div>
+            </xpath>
+        </field>
+    </record>
+</odoo>