From 067b4425968877102036509fbaadd7e318e0a26e Mon Sep 17 00:00:00 2001 From: NanoCode012 Date: Wed, 29 Jan 2025 11:22:10 +0700 Subject: [PATCH] chore: refactor SaveModelCallback to stop handle fractional save_steps (#2291) [skip ci] --- src/axolotl/utils/callbacks/__init__.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/axolotl/utils/callbacks/__init__.py b/src/axolotl/utils/callbacks/__init__.py index f1b459b6b..d92cb9d99 100644 --- a/src/axolotl/utils/callbacks/__init__.py +++ b/src/axolotl/utils/callbacks/__init__.py @@ -4,7 +4,6 @@ from __future__ import annotations import gc import logging -import math import os import traceback from shutil import copyfile @@ -830,13 +829,6 @@ class SaveModelCallback(TrainerCallback): # Save if state.global_step >= state.max_steps: control.should_save = True - elif ( - args.save_strategy == IntervalStrategy.STEPS - and state.save_steps < 1.0 - and state.global_step % math.ceil(state.save_steps * state.max_steps) == 0 - ): - # workaround to save model on fractional save_steps - control.should_save = True def on_train_end( # pylint: disable=unused-argument self, args, state, control, **kwargs