From 18cabc0c461c9178c90fcb080e40e7daa9c6c6f8 Mon Sep 17 00:00:00 2001 From: Wing Lian Date: Sat, 8 Jun 2024 09:48:30 -0400 Subject: [PATCH] fix for when sample_packing and eval_sample_packing are different (#1695) --- .../utils/config/models/input/v0_4_1/__init__.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/axolotl/utils/config/models/input/v0_4_1/__init__.py b/src/axolotl/utils/config/models/input/v0_4_1/__init__.py index 84e6bb19a..dbf9b02c0 100644 --- a/src/axolotl/utils/config/models/input/v0_4_1/__init__.py +++ b/src/axolotl/utils/config/models/input/v0_4_1/__init__.py @@ -908,6 +908,17 @@ class AxolotlInputConfig( "explicitly setting `eval_sample_packing` to match `sample_packing`" ) data["eval_sample_packing"] = True + + if ( + data.get("sample_packing") + and data.get("eval_sample_packing") is False + and data.get("remove_unused_columns") is None + ): + LOG.info( + "setting `remove_unused_columns: false` for when sample_packing and eval_sample_packing don't match" + ) + data["remove_unused_columns"] = False + return data @model_validator(mode="before")