From 1b8d4394411506f502670e019cdbff95b84aba9e Mon Sep 17 00:00:00 2001 From: Wing Lian Date: Thu, 17 Oct 2024 10:00:15 -0400 Subject: [PATCH] add test case --- tests/integrations/liger.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tests/integrations/liger.py b/tests/integrations/liger.py index 4a285f931..61540a57c 100644 --- a/tests/integrations/liger.py +++ b/tests/integrations/liger.py @@ -63,3 +63,18 @@ class TestValidation(BaseValidation): ) assert updated_cfg.liger_swiglu is None assert updated_cfg.liger_glu_activations is False + + def test_conflict_swiglu_ligergluactivation(self, minimal_cfg): + test_cfg = DictDefault( + { + "liger_swiglu": False, + "liger_glu_activations": True, + } + | minimal_cfg + ) + + with pytest.raises( + ValueError, + match=r".*You cannot have both `liger_swiglu` and `liger_glu_activation` set.*", + ): + validate_config(test_cfg)