tocmo0nlord/axolotl
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: address pr feedback

Browse Source
This commit is contained in:
NanoCode012
2025-05-16 14:36:38 +07:00
parent 00bfdb6b2b
commit 49888eccb9
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/axolotl/core/trainer_builder/rl.py
View File

@@ -175,10 +175,12 @@ class HFRLTrainerBuilder(TrainerBuilderBase):
trainer_kwargs = {} trainer_kwargs = {}
# Pop optimizer_cls_and_kwargs to trainer_kwargs # Pop optimizer_cls_and_kwargs to trainer_kwargs
if "optimizer_cls_and_kwargs" in training_args: if hasattr(training_args, "optimizer_cls_and_kwargs"):
trainer_kwargs["optimizer_cls_and_kwargs"] = training_args.pop( trainer_kwargs["optimizer_cls_and_kwargs"] = getattr(
"optimizer_cls_and_kwargs" training_args, "optimizer_cls_and_kwargs"
) )
# prevent duplication downstream
delattr(training_args, "optimizer_cls_and_kwargs")
if self.cfg.rl is RLType.IPO: if self.cfg.rl is RLType.IPO:
if self.cfg.dpo_label_smoothing: if self.cfg.dpo_label_smoothing:

8
src/axolotl/core/trainer_builder/sft.py
View File

@@ -346,10 +346,12 @@ class HFCausalTrainerBuilder(TrainerBuilderBase):
trainer_kwargs = {} trainer_kwargs = {}
# Pop optimizer_cls_and_kwargs to trainer_kwargs # Pop optimizer_cls_and_kwargs to trainer_kwargs
if "optimizer_cls_and_kwargs" in training_arguments_kwargs: if hasattr(training_arguments_kwargs, "optimizer_cls_and_kwargs"):
trainer_kwargs["optimizer_cls_and_kwargs"] = training_arguments_kwargs.pop( trainer_kwargs["optimizer_cls_and_kwargs"] = getattr(
"optimizer_cls_and_kwargs" training_arguments_kwargs, "optimizer_cls_and_kwargs"
) )
# prevent duplication downstream
delattr(training_arguments_kwargs, "optimizer_cls_and_kwargs")
if self.cfg.reward_model: if self.cfg.reward_model:
training_args_cls = AxolotlRewardConfig training_args_cls = AxolotlRewardConfig