tocmo0nlord/axolotl
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

checking for False is not sufficent for NoneType/unset configs

Browse Source
This commit is contained in:
Wing Lian
2023-05-27 08:43:48 -04:00
parent c3d256271e
commit 4c500f5830
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/axolotl/utils/validation.py
View File

@@ -5,12 +5,12 @@ def validate_config(cfg):
if cfg.adapter == "qlora": if cfg.adapter == "qlora":
if cfg.merge_lora: if cfg.merge_lora:
# can't merge qlora if loaded in 8bit or 4bit # can't merge qlora if loaded in 8bit or 4bit
assert cfg.load_in_8bit is False assert cfg.load_in_8bit is not True
assert cfg.load_4bit is False assert cfg.load_4bit is not True
assert cfg.load_in_4bit is False assert cfg.load_in_4bit is False
else: else:
assert cfg.load_in_8bit is False assert cfg.load_in_8bit is not True
assert cfg.load_4bit is False assert cfg.load_4bit is not True
assert cfg.load_in_4bit is True assert cfg.load_in_4bit is True
if not cfg.load_in_8bit and cfg.adapter == "lora": if not cfg.load_in_8bit and cfg.adapter == "lora":
logging.warning("We recommend setting `load_in_8bit: true` for LORA finetuning") logging.warning("We recommend setting `load_in_8bit: true` for LORA finetuning")