From 55d98db0d0a786cf26a3e4dec17b1fab7b3bdd31 Mon Sep 17 00:00:00 2001 From: Dan Saunders Date: Thu, 25 Sep 2025 16:08:35 -0400 Subject: [PATCH] fix --- scripts/benchmarks/deepseek_v3_moe_sweep.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/scripts/benchmarks/deepseek_v3_moe_sweep.py b/scripts/benchmarks/deepseek_v3_moe_sweep.py index a52a4bb64..944d48086 100644 --- a/scripts/benchmarks/deepseek_v3_moe_sweep.py +++ b/scripts/benchmarks/deepseek_v3_moe_sweep.py @@ -6,6 +6,7 @@ from __future__ import annotations import argparse import csv +import logging import sys from pathlib import Path from types import SimpleNamespace @@ -26,6 +27,8 @@ from scripts.benchmarks.deepseek_v3_moe import ( # noqa: E402 benchmark_deepseek_v3, ) +LOG = logging.getLogger(__name__) + def parse_args() -> argparse.Namespace: parser = argparse.ArgumentParser(description=__doc__) @@ -190,7 +193,7 @@ def main() -> None: # pragma: no cover - utility script ) print( f"{'model':>10} {'batch':>5} {'seq':>5} {'hidden':>7} {'experts':>7} {'topk':>4} {'groups':>6} {'backend':>8}" - f" {'baseline':>12} {'patched':>12} {'speedup':>8} {'b_vram':>8} {'p_vram':>8} {'acc':>5}" + f" {'baseline':>12} {'patched':>12} {'speedup':>8} {'b_vram':>8} {'p_vram':>8} {'diff':>10} {'acc':>5}" ) for cfg in grid: @@ -233,11 +236,15 @@ def main() -> None: # pragma: no cover - utility script print( f"{cfg['label']:>10} {cfg['batch']:>5} {cfg['seq_len']:>5} {cfg['hidden_size']:>7} {cfg['n_experts']:>7} {cfg['top_k']:>4} {cfg['groups']:>6} {backend:>8}" f" {result['baseline_ms']:>11.3f} ms {result['patched_ms']:>11.3f} ms {result['speedup']:>7.2f}x" - f" {baseline_vram_mib:>8.1f} {patched_vram_mib:>8.1f} {status:>5}" + f" {baseline_vram_mib:>8.1f} {patched_vram_mib:>8.1f} {result['max_diff']:>10.3e} {status:>5}" ) if not result["accuracy_ok"]: - raise RuntimeError( - f"Accuracy check failed for config {cfg}: max diff {result['max_diff']:.3e} exceeds tolerance {ACCURACY_TOLERANCE:.1e}" + LOG.warning( + "Accuracy tolerance exceeded for %s backend=%s: diff=%.3e (> %.1e)", + cfg["label"], + backend, + result["max_diff"], + ACCURACY_TOLERANCE, ) if args.output: