add mocks for loading datasets in cli train tests (#2497) [skip ci]

* add mocks for loading datasets in cli train tests

* Apply suggestions from code review to fix patched module for preprocess

Co-authored-by: NanoCode012 <nano@axolotl.ai>

---------

Co-authored-by: NanoCode012 <nano@axolotl.ai>
This commit is contained in:
Wing Lian
2025-04-11 09:51:59 -04:00
committed by GitHub
parent 22c562533d
commit 7e7180fa10
2 changed files with 60 additions and 50 deletions

View File

@@ -2,7 +2,7 @@
import shutil import shutil
from pathlib import Path from pathlib import Path
from unittest.mock import patch from unittest.mock import MagicMock, patch
import pytest import pytest
@@ -26,6 +26,9 @@ def test_preprocess_config_not_found(cli_runner):
def test_preprocess_basic(cli_runner, config_path): def test_preprocess_basic(cli_runner, config_path):
"""Test basic preprocessing with minimal config""" """Test basic preprocessing with minimal config"""
with patch("axolotl.cli.preprocess.do_cli") as mock_do_cli: with patch("axolotl.cli.preprocess.do_cli") as mock_do_cli:
with patch("axolotl.cli.preprocess.load_datasets") as mock_load_datasets:
mock_load_datasets.return_value = MagicMock()
result = cli_runner.invoke(cli, ["preprocess", str(config_path)]) result = cli_runner.invoke(cli, ["preprocess", str(config_path)])
assert result.exit_code == 0 assert result.exit_code == 0
@@ -54,6 +57,9 @@ def test_preprocess_custom_path(cli_runner, tmp_path, valid_test_config):
config_path.write_text(valid_test_config) config_path.write_text(valid_test_config)
with patch("axolotl.cli.preprocess.do_cli") as mock_do_cli: with patch("axolotl.cli.preprocess.do_cli") as mock_do_cli:
with patch("axolotl.cli.preprocess.load_datasets") as mock_load_datasets:
mock_load_datasets.return_value = MagicMock()
result = cli_runner.invoke( result = cli_runner.invoke(
cli, cli,
[ [

View File

@@ -29,6 +29,8 @@ class TestTrainCommand(BaseCliTest):
with patch("axolotl.cli.train.train") as mock_train: with patch("axolotl.cli.train.train") as mock_train:
mock_train.return_value = (MagicMock(), MagicMock(), MagicMock()) mock_train.return_value = (MagicMock(), MagicMock(), MagicMock())
with patch("axolotl.cli.train.load_datasets") as mock_load_datasets:
mock_load_datasets.return_value = MagicMock()
result = cli_runner.invoke( result = cli_runner.invoke(
cli, cli,
@@ -49,6 +51,8 @@ class TestTrainCommand(BaseCliTest):
with patch("axolotl.cli.train.train") as mock_train: with patch("axolotl.cli.train.train") as mock_train:
mock_train.return_value = (MagicMock(), MagicMock(), MagicMock()) mock_train.return_value = (MagicMock(), MagicMock(), MagicMock())
with patch("axolotl.cli.train.load_datasets") as mock_load_datasets:
mock_load_datasets.return_value = MagicMock()
result = cli_runner.invoke( result = cli_runner.invoke(
cli, cli,