From a20f17689b0f78ed1e15e5ce2ec1983dc2bb3fe9 Mon Sep 17 00:00:00 2001 From: Wing Lian Date: Fri, 31 Jan 2025 20:19:20 -0500 Subject: [PATCH] set MODAL_IMAGE_BUILDER_VERSION=2024.10 to 2024.10 to test latest builder (#2302) * set MODAL_IMAGE_BUILDER_VERSION=2024.10 to 2024.10 to test latest builder * chore: lint * remove fastapi and pydantic extras --- .github/workflows/tests.yml | 2 ++ cicd/tests.py | 16 ++++++---------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index b530908fd..709845fc6 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -228,6 +228,7 @@ jobs: echo "AXOLOTL_ARGS=${{ matrix.axolotl_args}}" >> $GITHUB_ENV echo "AXOLOTL_EXTRAS=${{ matrix.axolotl_extras}}" >> $GITHUB_ENV echo "CUDA=${{ matrix.cuda }}" >> $GITHUB_ENV + echo "MODAL_IMAGE_BUILDER_VERSION=2024.10" >> $GITHUB_ENV echo "N_GPUS=${{ matrix.num_gpus }}" >> $GITHUB_ENV - name: Run tests job on Modal run: | @@ -268,6 +269,7 @@ jobs: echo "AXOLOTL_ARGS=${{ matrix.axolotl_args}}" >> $GITHUB_ENV echo "AXOLOTL_EXTRAS=${{ matrix.axolotl_extras}}" >> $GITHUB_ENV echo "CUDA=${{ matrix.cuda }}" >> $GITHUB_ENV + echo "MODAL_IMAGE_BUILDER_VERSION=2024.10" >> $GITHUB_ENV echo "N_GPUS=${{ matrix.num_gpus }}" >> $GITHUB_ENV - name: Run tests job on Modal run: | diff --git a/cicd/tests.py b/cicd/tests.py index 6fe701632..b934d5316 100644 --- a/cicd/tests.py +++ b/cicd/tests.py @@ -38,16 +38,12 @@ temp_dir = tempfile.mkdtemp() with open(pathlib.Path(temp_dir) / "Dockerfile", "w", encoding="utf-8") as f: f.write(dockerfile_contents) -cicd_image = ( - Image.from_dockerfile( - pathlib.Path(temp_dir) / "Dockerfile", - context_mount=None, - force_build=True, - gpu="A10G", - ) - .env(df_args) - .pip_install("fastapi==0.110.0", "pydantic==2.6.3") -) +cicd_image = Image.from_dockerfile( + pathlib.Path(temp_dir) / "Dockerfile", + context_mount=None, + force_build=True, + gpu="A10G", +).env(df_args) app = App("Axolotl CI/CD", secrets=[])