From ab534d75ba9bdf88b823100869d8d88190ad8890 Mon Sep 17 00:00:00 2001 From: Wing Lian Date: Sat, 16 Sep 2023 16:11:57 -0400 Subject: [PATCH] don't add position_ids for evals (#591) --- src/axolotl/utils/trainer.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/axolotl/utils/trainer.py b/src/axolotl/utils/trainer.py index ee3e9d2f2..c36862b67 100644 --- a/src/axolotl/utils/trainer.py +++ b/src/axolotl/utils/trainer.py @@ -403,10 +403,11 @@ def process_datasets_for_packing(cfg, train_dataset, eval_dataset): if cfg.sample_packing: train_dataset = train_dataset.map(add_position_ids, num_proc=os.cpu_count()) - if eval_dataset: - eval_dataset = eval_dataset.map( - add_position_ids, num_proc=os.cpu_count() - ) + if cfg.eval_sample_packing is not False: + if eval_dataset: + eval_dataset = eval_dataset.map( + add_position_ids, num_proc=os.cpu_count() + ) return train_dataset, eval_dataset