From b5198d873491f3e4576511eed88210ae2c90561a Mon Sep 17 00:00:00 2001 From: Wing Lian Date: Sat, 2 Aug 2025 20:57:00 -0400 Subject: [PATCH] granite chat multipack support and example --- src/axolotl/monkeypatch/multipack.py | 2 ++ src/axolotl/utils/schemas/validation.py | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/src/axolotl/monkeypatch/multipack.py b/src/axolotl/monkeypatch/multipack.py index 9dc04c7b4..f3bcadacc 100644 --- a/src/axolotl/monkeypatch/multipack.py +++ b/src/axolotl/monkeypatch/multipack.py @@ -36,6 +36,8 @@ SUPPORTED_MULTIPACK_MODEL_TYPES = [ "glm", "glm4", "smollm3", + "granite", + "granitemoe", ] diff --git a/src/axolotl/utils/schemas/validation.py b/src/axolotl/utils/schemas/validation.py index 02e80dd8e..302107cd3 100644 --- a/src/axolotl/utils/schemas/validation.py +++ b/src/axolotl/utils/schemas/validation.py @@ -644,6 +644,19 @@ class LoRAValidationMixin: ) return data + @model_validator(mode="before") + @classmethod + def check_lora_dropout_parameters(cls, data): + if ( + data.get("lora_dropout", 0.0) + and data.get("lora_dropout") > 0.0 + and data.get("lora_target_parameters") + ): + # lora.ParamWrapper does not work with lora_dropout != 0 + raise ValueError( + "`lora_dropout` does not work when using `lora_target_parameters`" + ) + class RLValidationMixin: """Validation methods related to RL training configuration."""