assume empty lora dropout means 0.0 and add tests (#2243)

* assume empty lora dropout means 0.0 and add tests

* remove un-necessary arg

* refactor based on pr feedback:

* chore: lint
This commit is contained in:
Wing Lian
2025-01-13 10:44:11 -05:00
committed by GitHub
parent dd26cc3c0f
commit bc1c9c20e3
2 changed files with 76 additions and 0 deletions

View File

@@ -367,6 +367,13 @@ class LoraConfig(BaseModel):
loraplus_lr_embedding = float(loraplus_lr_embedding)
return loraplus_lr_embedding
@model_validator(mode="before")
@classmethod
def validate_lora_dropout(cls, data):
if data.get("adapter") is not None and data.get("lora_dropout") is None:
data["lora_dropout"] = 0.0
return data
class ReLoRAConfig(BaseModel):
"""ReLoRA configuration subset"""