tocmo0nlord/axolotl
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix: warmup_steps: 0 & warmup_ratio: 0 not disabling warmup (#3254)

Browse Source 
* fix unintentional falsy checks

* chore: lint

---------

Co-authored-by: NanoCode012 <nano@axolotl.ai>
This commit is contained in:
xzuyn
2025-11-10 22:32:06 -05:00
committed by GitHub
parent b54f9c942b
commit dd78f2e0cc
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/axolotl/core/builders/base.py
View File

@@ -196,9 +196,9 @@ class TrainerBuilderBase(abc.ABC):
): ):
warmup_steps = 0 warmup_steps = 0
warmup_ratio = 0.0 warmup_ratio = 0.0
if self.cfg.warmup_steps: if self.cfg.warmup_steps is not None:
warmup_steps = self.cfg.warmup_steps warmup_steps = self.cfg.warmup_steps
elif self.cfg.warmup_ratio: elif self.cfg.warmup_ratio is not None:
if total_num_steps: if total_num_steps:
warmup_steps = max(int(self.cfg.warmup_ratio * total_num_steps), 0) warmup_steps = max(int(self.cfg.warmup_ratio * total_num_steps), 0)
else: else:

1
tests/e2e/integrations/test_liger.py
View File

@@ -3,6 +3,7 @@ Simple end-to-end test for Liger integration
""" """
import pytest import pytest
from axolotl.common.datasets import load_datasets from axolotl.common.datasets import load_datasets
from axolotl.train import train from axolotl.train import train
from axolotl.utils.config import normalize_config, prepare_plugins, validate_config from axolotl.utils.config import normalize_config, prepare_plugins, validate_config