From e0a2523a3bf875c9e82de0ecea67371e634553f1 Mon Sep 17 00:00:00 2001 From: Wing Lian Date: Wed, 13 Aug 2025 06:39:39 -0400 Subject: [PATCH] Workaround to unblock docs build in main (#3055) Co-authored-by: Salman Mohammadi --- TODO.md | 10 ---------- src/axolotl/cli/utils/train.py | 6 ++---- 2 files changed, 2 insertions(+), 14 deletions(-) delete mode 100644 TODO.md diff --git a/TODO.md b/TODO.md deleted file mode 100644 index 2002bbbaf..000000000 --- a/TODO.md +++ /dev/null @@ -1,10 +0,0 @@ -# todo list - -- [] Validation of parameters for combinations that won't work - - - -## things that are known not to work - -- FSDP offload and gradient_checkpointing - https://github.com/pytorch/pytorch/issues/82203 -- adamw_bnb_8bit doesn't play well with FSDP offload diff --git a/src/axolotl/cli/utils/train.py b/src/axolotl/cli/utils/train.py index f1ac857b3..31b0bcf58 100644 --- a/src/axolotl/cli/utils/train.py +++ b/src/axolotl/cli/utils/train.py @@ -67,14 +67,12 @@ def build_command(base_cmd: list[str], options: dict[str, Any]) -> list[str]: def generate_config_files(config: str, sweep: str | None) -> Iterator[tuple[str, bool]]: """ - Generate list of configuration files to process. + Generate list of configuration files to process. Yields a tuple of the configuration file name and a boolean indicating + whether this is a group of configurations (i.e., a sweep). Args: config: Base configuration file sweep: Sweep configuration file - - Yields: - Tuple of configuration file name and whether this is a group of configurations """ if not sweep: