Feat: Add warmup_ratio (#893)

* Feat: Add warmup_ratio * fix: update readme with more details on conflict
2023-11-25 12:15:43 +09:00
parent 9fc29e082b
commit fb12895a17
4 changed files with 43 additions and 6 deletions
--- a/tests/test_validation.py
+++ b/tests/test_validation.py
@@ -649,3 +649,33 @@ class ValidationTest(unittest.TestCase):
        )

        validate_config(cfg)
+
+    def test_warmup_step_no_conflict(self):
+        cfg = DictDefault(
+            {
+                "warmup_steps": 10,
+                "warmup_ratio": 0.1,
+            }
+        )
+
+        with pytest.raises(
+            ValueError,
+            match=r".*warmup_steps and warmup_ratio are mutually exclusive*",
+        ):
+            validate_config(cfg)
+
+        cfg = DictDefault(
+            {
+                "warmup_steps": 10,
+            }
+        )
+
+        validate_config(cfg)
+
+        cfg = DictDefault(
+            {
+                "warmup_ratio": 0.1,
+            }
+        )
+
+        validate_config(cfg)