update for pr feedback

This commit is contained in:
Wing Lian
2023-05-28 14:23:27 -04:00
parent 1c33eb88a7
commit fd5f9656a2

View File

@@ -95,14 +95,7 @@ class ValidationTest(unittest.TestCase):
validate_config(cfg) validate_config(cfg)
def test_hf_use_auth_token(self): def test_hf_use_auth_token(self):
base_cfg = DictDefault( cfg = DictDefault(
{
"push_dataset_to_hub": None,
"hf_use_auth_token": None,
}
)
cfg = base_cfg | DictDefault(
{ {
"push_dataset_to_hub": "namespace/repo", "push_dataset_to_hub": "namespace/repo",
} }
@@ -111,7 +104,7 @@ class ValidationTest(unittest.TestCase):
with pytest.raises(ValueError, match=r".*hf_use_auth_token.*"): with pytest.raises(ValueError, match=r".*hf_use_auth_token.*"):
validate_config(cfg) validate_config(cfg)
cfg = base_cfg | DictDefault( cfg = DictDefault(
{ {
"push_dataset_to_hub": "namespace/repo", "push_dataset_to_hub": "namespace/repo",
"hf_use_auth_token": True, "hf_use_auth_token": True,