Compare commits

...

3 Commits

Author SHA1 Message Date
Dan Saunders
4870638734 initial impl of streaming preprocessing 2025-08-19 23:10:54 +00:00
Dan Saunders
b25078397c nit 2025-08-19 18:12:09 +00:00
Dan Saunders
ba681125d7 separate streaming and pretraining 2025-08-19 18:05:05 +00:00
8 changed files with 392 additions and 23 deletions

View File

@@ -40,6 +40,7 @@ from axolotl.utils.collators import (
BatchSamplerDataCollatorForSeq2Seq, BatchSamplerDataCollatorForSeq2Seq,
DataCollatorForSeq2Seq, DataCollatorForSeq2Seq,
MambaDataCollator, MambaDataCollator,
StreamingDataCollator,
V2BatchSamplerDataCollatorForSeq2Seq, V2BatchSamplerDataCollatorForSeq2Seq,
) )
from axolotl.utils.collators.mm_chat import MultiModalChatDataCollator from axolotl.utils.collators.mm_chat import MultiModalChatDataCollator
@@ -422,6 +423,17 @@ class HFCausalTrainerBuilder(TrainerBuilderBase):
is_eval=False, is_eval=False,
**kwargs, **kwargs,
): ):
from datasets import IterableDataset
if isinstance(self.train_dataset, IterableDataset) and not is_eval:
LOG.info("Using StreamingDataCollator")
return StreamingDataCollator(
tokenizer=self.tokenizer,
cfg=self.cfg,
prompter=None,
**kwargs,
)
if training_args.pretraining: if training_args.pretraining:
if ( if (
self.cfg.pretraining_sample_concatenation is False self.cfg.pretraining_sample_concatenation is False

View File

@@ -43,7 +43,11 @@ class TokenizedPromptDataset(Dataset):
) )
def process(self, dataset): def process(self, dataset):
features = dataset.features.keys() # For IterableDataset, we can't access features upfront
# We'll need to infer from the first batch
features = None
if hasattr(dataset, "features") and dataset.features:
features = dataset.features.keys()
map_kwargs = {} map_kwargs = {}
if self.prompt_tokenizer.supports_batched: if self.prompt_tokenizer.supports_batched:
@@ -54,18 +58,29 @@ class TokenizedPromptDataset(Dataset):
hasattr(self.prompt_tokenizer, "filter_rows") hasattr(self.prompt_tokenizer, "filter_rows")
and self.prompt_tokenizer.filter_rows and self.prompt_tokenizer.filter_rows
): ):
filter_kwargs = {"desc": "Strategy Filtering Rows"}
# Only add num_proc for regular datasets
if features is not None:
filter_kwargs["num_proc"] = self.process_count
dataset = dataset.filter( dataset = dataset.filter(
self.prompt_tokenizer.filter_rows, self.prompt_tokenizer.filter_rows,
num_proc=self.process_count, **filter_kwargs,
desc="Strategy Filtering Rows",
) )
map_kwargs = {
**map_kwargs,
"desc": "Tokenizing Prompts",
}
# Only add remove_columns for regular datasets
if features is not None:
map_kwargs["remove_columns"] = features
map_kwargs["num_proc"] = self.process_count
map_kwargs["keep_in_memory"] = self.keep_in_memory
return dataset.map( return dataset.map(
self.prompt_tokenizer.tokenize_prompt, self.prompt_tokenizer.tokenize_prompt,
num_proc=self.process_count,
remove_columns=features,
keep_in_memory=self.keep_in_memory,
desc="Tokenizing Prompts",
**map_kwargs, **map_kwargs,
) )

View File

@@ -1,11 +1,19 @@
""" """Shared axolotl collators for multipack, mamba, multimodal, etc."""
shared axolotl collators for multipack, mamba, multimodal
"""
from .batching import ( # noqa: F401 from .batching import (
BatchSamplerDataCollatorForSeq2Seq, BatchSamplerDataCollatorForSeq2Seq,
DataCollatorForSeq2Seq, DataCollatorForSeq2Seq,
PretrainingBatchSamplerDataCollatorForSeq2Seq, PretrainingBatchSamplerDataCollatorForSeq2Seq,
V2BatchSamplerDataCollatorForSeq2Seq, V2BatchSamplerDataCollatorForSeq2Seq,
) )
from .mamba import MambaDataCollator # noqa: F401 from .mamba import MambaDataCollator
from .streaming import StreamingDataCollator
__all__ = [
"BatchSamplerDataCollatorForSeq2Seq",
"DataCollatorForSeq2Seq",
"PretrainingBatchSamplerDataCollatorForSeq2Seq",
"V2BatchSamplerDataCollatorForSeq2Seq",
"MambaDataCollator",
"StreamingDataCollator",
]

View File

@@ -0,0 +1,146 @@
from dataclasses import dataclass
from typing import Any, List
import torch
from transformers import PreTrainedTokenizerBase, default_data_collator
from transformers.utils import PaddingStrategy
from axolotl.prompters import Prompter
from axolotl.utils.dict import DictDefault
@dataclass
class StreamingDataCollator:
tokenizer: PreTrainedTokenizerBase
cfg: DictDefault
prompter: Prompter | None = None
padding: bool | str | PaddingStrategy = True
max_length: int | None = None
pad_to_multiple_of: int | None = None
label_pad_token_id: int = -100
return_tensors: str = "pt"
def __post_init__(self):
if self.max_length is None:
self.max_length = self.cfg.sequence_len
def __call__(self, raw_batch: List[dict]) -> dict[str, Any]:
processed_samples = []
for raw_sample in raw_batch:
formatted_sample = raw_sample
if self.prompter:
formatted_sample = self._apply_prompt_formatting(raw_sample)
tokenized_sample = self._tokenize_sample(formatted_sample)
if len(tokenized_sample["input_ids"]) > self.max_length:
tokenized_sample = self._truncate_sample(tokenized_sample)
if tokenized_sample.get("input_ids"):
processed_samples.append(tokenized_sample)
return self._pad_and_batch(processed_samples)
def _apply_prompt_formatting(self, raw_sample: dict) -> dict:
formatted_text = self.prompter.build_prompt(
instruction=raw_sample.get("instruction", ""),
input=raw_sample.get("input", ""),
output=raw_sample.get("output", ""),
)
return {"text": formatted_text}
def _tokenize_sample(self, sample: dict) -> dict:
text = sample.get("text", sample.get("content", ""))
if not text:
instruction = sample.get("instruction", "")
input_text = sample.get("input", "")
output_text = sample.get("output", "")
parts = []
if instruction:
parts.append(f"Instruction: {instruction}")
if input_text:
parts.append(f"Input: {input_text}")
if output_text:
parts.append(f"Output: {output_text}")
text = "\n".join(parts)
if not text:
return {"input_ids": [], "attention_mask": [], "labels": []}
tokenized = self.tokenizer(
text,
truncation=False,
padding=False,
return_tensors=None,
)
tokenized["labels"] = tokenized["input_ids"].copy()
return tokenized
def _truncate_sample(self, tokenized_sample: dict) -> dict:
max_len = self.max_length
for key in ["input_ids", "attention_mask", "labels"]:
if key in tokenized_sample:
tokenized_sample[key] = tokenized_sample[key][:max_len]
return tokenized_sample
def _pad_and_batch(self, processed_samples: List[dict]) -> dict[str, Any]:
if not processed_samples:
processed_samples = [
{
"input_ids": [self.tokenizer.eos_token_id],
"attention_mask": [1],
"labels": [self.tokenizer.eos_token_id],
}
]
batch_samples = []
for sample in processed_samples:
batch_sample = {}
for key, value in sample.items():
if key in ["input_ids", "attention_mask", "labels"]:
batch_sample[key] = torch.tensor(value, dtype=torch.long)
batch_samples.append(batch_sample)
if self.padding:
max_len_in_batch = max(len(sample["input_ids"]) for sample in batch_samples)
for sample in batch_samples:
current_len = len(sample["input_ids"])
pad_len = max_len_in_batch - current_len
if pad_len > 0:
pad_token_id = (
self.tokenizer.pad_token_id or self.tokenizer.eos_token_id
)
sample["input_ids"] = torch.cat(
[
sample["input_ids"],
torch.full((pad_len,), pad_token_id, dtype=torch.long),
]
)
sample["attention_mask"] = torch.cat(
[
sample["attention_mask"],
torch.zeros(pad_len, dtype=torch.long),
]
)
sample["labels"] = torch.cat(
[
sample["labels"],
torch.full(
(pad_len,), self.label_pad_token_id, dtype=torch.long
),
]
)
batch = {}
for key in ["input_ids", "attention_mask", "labels"]:
if key in batch_samples[0]:
batch[key] = torch.stack([sample[key] for sample in batch_samples])
return batch

View File

@@ -9,6 +9,7 @@ from datasets import (
Dataset, Dataset,
DatasetDict, DatasetDict,
IterableDataset, IterableDataset,
IterableDatasetDict,
load_dataset, load_dataset,
) )
from transformers import PreTrainedTokenizer, ProcessorMixin from transformers import PreTrainedTokenizer, ProcessorMixin
@@ -43,6 +44,18 @@ from axolotl.utils.trainer import (
LOG = get_logger(__name__) LOG = get_logger(__name__)
def _determine_streaming_mode(cfg: DictDefault) -> bool:
"""Determine if we should use streaming mode based on config."""
if cfg.streaming is not None:
return cfg.streaming
# Default to streaming for pretraining datasets
if cfg.pretraining_dataset:
return True
return False
@retry_on_request_exceptions(max_retries=3, delay=5) @retry_on_request_exceptions(max_retries=3, delay=5)
def prepare_datasets( def prepare_datasets(
cfg: DictDefault, cfg: DictDefault,
@@ -61,11 +74,52 @@ def prepare_datasets(
Returns: Returns:
Tuple of (train_dataset, eval_dataset, total_steps, prompters). Tuple of (train_dataset, eval_dataset, total_steps, prompters).
""" """
if cfg.pretraining_dataset: streaming_mode = _determine_streaming_mode(cfg)
return _prepare_pretraining_dataset(
cfg, tokenizer, processor, preprocess_iterable if streaming_mode:
if cfg.pretraining_dataset:
return _prepare_streaming_pretraining_dataset(cfg, tokenizer, processor)
else:
return _prepare_streaming_sft_dataset(cfg, tokenizer, processor)
else:
if cfg.pretraining_dataset:
return _prepare_pretraining_dataset(
cfg, tokenizer, processor, preprocess_iterable=False
)
else:
return _prepare_standard_dataset(
cfg, tokenizer, processor, preprocess_iterable=False
)
def _prepare_streaming_sft_dataset(
cfg: DictDefault,
tokenizer: PreTrainedTokenizer,
processor: ProcessorMixin | None,
) -> tuple[IterableDataset, Dataset | None, int, list[Prompter | None]]:
LOG.info("Loading streaming datasets")
raw_datasets = _load_raw_datasets_for_streaming(cfg, split="train")
eval_dataset = None
if cfg.test_datasets:
eval_raw_datasets = _load_raw_datasets_for_streaming(
cfg, split="test", dataset_configs=cfg.test_datasets
) )
return _prepare_standard_dataset(cfg, tokenizer, processor, preprocess_iterable) eval_dataset = _process_eval_dataset_minimal(
eval_raw_datasets, cfg, tokenizer, processor
)
elif cfg.val_set_size:
LOG.info("Validation splits not supported for streaming datasets")
if not cfg.max_steps:
raise ValueError("max_steps must be set when using streaming datasets")
total_num_steps = cfg.max_steps
LOG.info(f"Maximum steps: {total_num_steps}")
prompters = [None] * len(cfg.datasets) if cfg.datasets else []
return raw_datasets, eval_dataset, total_num_steps, prompters
def _prepare_standard_dataset( def _prepare_standard_dataset(
@@ -373,7 +427,7 @@ def _load_and_process_single_dataset(
d_base_type, d_prompt_style = _parse_dataset_type(dataset_config.type) d_base_type, d_prompt_style = _parse_dataset_type(dataset_config.type)
# Select the appropriate split # Select the appropriate split
if isinstance(dataset, DatasetDict): if isinstance(dataset, (DatasetDict, IterableDatasetDict)):
if dataset_config.split and dataset_config.split in dataset: if dataset_config.split and dataset_config.split in dataset:
dataset = dataset[dataset_config.split] dataset = dataset[dataset_config.split]
elif split in dataset: elif split in dataset:
@@ -512,3 +566,78 @@ def _load_and_prepare_datasets(
train_dataset, eval_dataset = _handle_test_dataset_split(dataset, cfg) train_dataset, eval_dataset = _handle_test_dataset_split(dataset, cfg)
return train_dataset, eval_dataset, prompters return train_dataset, eval_dataset, prompters
def _load_raw_datasets_for_streaming(
cfg: DictDefault, split: str = "train", dataset_configs: list | None = None
) -> IterableDataset:
configs = (
dataset_configs
if dataset_configs is not None
else (cfg.datasets if split == "train" else cfg.test_datasets)
)
if not configs:
raise ValueError(f"No dataset configurations found for split '{split}'")
datasets = []
for dataset_config in datasets_with_name_generator(configs):
raw_dataset = load_dataset_with_config(
dataset_config, cfg.hf_use_auth_token, streaming=True
)
if isinstance(raw_dataset, (DatasetDict, IterableDatasetDict)):
if dataset_config.split and dataset_config.split in raw_dataset:
raw_dataset = raw_dataset[dataset_config.split]
elif split in raw_dataset:
raw_dataset = raw_dataset[split]
else:
raise ValueError(
f"no {split} split found for dataset {dataset_config.path}, "
"you may specify a split with 'split: ...'"
)
datasets.append(raw_dataset)
if len(datasets) == 1:
return datasets[0]
else:
return merge_datasets(datasets, cfg)
def _process_eval_dataset_minimal(
raw_dataset: IterableDataset,
cfg: DictDefault,
tokenizer: PreTrainedTokenizer,
processor: ProcessorMixin | None,
) -> Dataset | None:
LOG.info("Eval dataset processing skipped for streaming")
return None
def _prepare_streaming_pretraining_dataset(
cfg: DictDefault,
tokenizer: PreTrainedTokenizer,
processor: ProcessorMixin | None,
) -> tuple[IterableDataset, Dataset | None, int, list[Prompter | None]]:
pretraining_config = _extract_pretraining_config(cfg)
train_dataset = load_dataset_with_config(
pretraining_config, cfg.hf_use_auth_token, streaming=True
)
if isinstance(train_dataset, (DatasetDict, IterableDatasetDict)):
if pretraining_config.split and pretraining_config.split in train_dataset:
train_dataset = train_dataset[pretraining_config.split]
elif "train" in train_dataset:
train_dataset = train_dataset["train"]
else:
raise ValueError("no train split found for pretraining dataset")
if not cfg.max_steps:
raise ValueError("max_steps must be set when using streaming datasets")
total_num_steps = cfg.max_steps
LOG.info(f"Maximum steps: {total_num_steps}")
return train_dataset, None, total_num_steps, []

View File

@@ -190,12 +190,18 @@ def handle_long_seq_in_dataset(
Returns: Returns:
Filtered dataset with long sequences removed. Filtered dataset with long sequences removed.
""" """
if "input_ids" not in dataset.column_names: if hasattr(dataset, "column_names") and dataset.column_names:
LOG.warning( if "input_ids" not in dataset.column_names:
"Dataset does not contain 'input_ids' column. Skip drop long seq. This is " LOG.warning(
"expected for reward modeling." "Dataset does not contain 'input_ids' column. Skip drop long seq. This is "
) "expected for reward modeling."
return dataset )
return dataset
else:
# For IterableDataset, we can't check columns upfront, so skip for streaming
if isinstance(dataset, IterableDataset):
LOG.info("Skipping drop_long_seq for streaming datasets (not compatible)")
return dataset
drop_long = functools.partial( drop_long = functools.partial(
drop_long_seq, drop_long_seq,

View File

@@ -932,6 +932,34 @@ class AxolotlInputConfig(
fix_untrained_tokens: int | list[int] | None = None fix_untrained_tokens: int | list[int] | None = None
streaming: bool | None = Field(
default=None,
json_schema_extra={
"description": "Whether to use streaming datasets (IterableDataset) for processing large datasets that don't fit in memory. When True, data is loaded on-demand during training without upfront preprocessing. Requires max_steps to be set. Pre-training datasets default to streaming unless explicitly set to False."
},
)
streaming_dataset_mixing_strategy: str | None = Field(
default="round_robin",
json_schema_extra={
"description": "Strategy for mixing multiple streaming datasets: 'round_robin' (equal sampling), 'weighted' (use streaming_mixing_weights), or 'random' (random sampling with equal probability)."
},
)
streaming_mixing_weights: list[float] | None = Field(
default=None,
json_schema_extra={
"description": "Weights for weighted mixing strategy when using multiple streaming datasets. Must sum to 1.0 and have same length as datasets list. Only used when streaming_dataset_mixing_strategy='weighted'."
},
)
streaming_buffer_per_dataset: int | None = Field(
default=1000,
json_schema_extra={
"description": "Buffer size per dataset when mixing multiple streaming datasets. Higher values may improve mixing quality but use more memory."
},
)
# INTERNALS - document for now, generally not set externally # INTERNALS - document for now, generally not set externally
is_preprocess: bool | None = None is_preprocess: bool | None = None
preprocess_iterable: bool | None = None preprocess_iterable: bool | None = None

View File

@@ -1337,6 +1337,30 @@ class GRPOVllmValidationMixin:
# pylint: disable=too-many-ancestors # pylint: disable=too-many-ancestors
class StreamingValidationMixin:
"""Validation methods related to streaming datasets."""
@model_validator(mode="after")
def check_streaming_requires_max_steps(self):
"""Ensure max_steps is set when using streaming datasets."""
# Check if streaming is explicitly enabled
streaming_enabled = getattr(self, "streaming", None) is True
# Check if pretraining dataset exists (defaults to streaming)
has_pretraining = getattr(self, "pretraining_dataset", None) is not None
streaming_default_for_pretraining = (
has_pretraining and getattr(self, "streaming", None) is None
)
# If streaming is enabled (explicitly or by default for pretraining)
if streaming_enabled or streaming_default_for_pretraining:
max_steps = getattr(self, "max_steps", None)
if not max_steps:
raise ValueError("max_steps must be set when using streaming datasets")
return self
class ValidationMixin( class ValidationMixin(
DatasetValidationMixin, DatasetValidationMixin,
AttentionValidationMixin, AttentionValidationMixin,
@@ -1347,6 +1371,7 @@ class ValidationMixin(
SystemValidationMixin, SystemValidationMixin,
ChatTemplateValidationMixin, ChatTemplateValidationMixin,
PretrainingValidationMixin, PretrainingValidationMixin,
StreamingValidationMixin,
ModelCompatibilityValidationMixin, ModelCompatibilityValidationMixin,
ComplexValidationMixin, ComplexValidationMixin,
GRPOVllmValidationMixin, GRPOVllmValidationMixin,