From 15afe51d9c3b991152fa4eda8241c4104c2c2edc Mon Sep 17 00:00:00 2001
From: Carlos Garcia <mr.garcia09@gmail.com>
Date: Fri, 24 Apr 2026 21:20:40 -0400
Subject: [PATCH] fix(addon): resolve all Odoo 18 install errors

- security/res_groups.xml: fully qualify ref('group_ai_user') with module prefix
- data/ir_cron.xml: remove numbercall field (removed in Odoo 17/18)
- views/menus.xml: remove web_icon referencing missing static/src/img/icon.png
- controllers/webhook.py: use get_json() instead of deprecated json.loads(data)
- security/ir.model.access.csv: use fully-qualified group external IDs (prior commit)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 addons/activeblue_ai/controllers/webhook.py  | 5 ++---
 addons/activeblue_ai/data/ir_cron.xml        | 4 ----
 addons/activeblue_ai/security/res_groups.xml | 2 +-
 addons/activeblue_ai/views/menus.xml         | 1 -
 4 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/addons/activeblue_ai/controllers/webhook.py b/addons/activeblue_ai/controllers/webhook.py
index 8fb85dd..bb756b0 100644
--- a/addons/activeblue_ai/controllers/webhook.py
+++ b/addons/activeblue_ai/controllers/webhook.py
@@ -25,9 +25,8 @@ class AiWebhookController(http.Controller):
         if bot and bot.webhook_secret:
             pass  # IP check handled at network level via ALLOWED_CALLBACK_IP env var in agent service
 
-        try:
-            data = json.loads(request.httprequest.data)
-        except Exception:
+        data = request.httprequest.get_json(silent=True) or {}
+        if not data:
             return Response(status=400)
 
         event_type = data.get('event', '')
diff --git a/addons/activeblue_ai/data/ir_cron.xml b/addons/activeblue_ai/data/ir_cron.xml
index e2e8bcb..757bb4f 100644
--- a/addons/activeblue_ai/data/ir_cron.xml
+++ b/addons/activeblue_ai/data/ir_cron.xml
@@ -8,7 +8,6 @@
             <field name="code">model.cron_ping_all()</field>
             <field name="interval_number">5</field>
             <field name="interval_type">minutes</field>
-            <field name="numbercall">-1</field>
             <field name="active">True</field>
         </record>
 
@@ -19,7 +18,6 @@
             <field name="code">model.sync_from_service()</field>
             <field name="interval_number">1</field>
             <field name="interval_type">hours</field>
-            <field name="numbercall">-1</field>
             <field name="active">True</field>
         </record>
 
@@ -30,7 +28,6 @@
             <field name="code">model.cron_cleanup_old()</field>
             <field name="interval_number">1</field>
             <field name="interval_type">days</field>
-            <field name="numbercall">-1</field>
             <field name="active">True</field>
         </record>
 
@@ -41,7 +38,6 @@
             <field name="code">model.cron_cleanup()</field>
             <field name="interval_number">1</field>
             <field name="interval_type">days</field>
-            <field name="numbercall">-1</field>
             <field name="active">True</field>
         </record>
     </data>
diff --git a/addons/activeblue_ai/security/res_groups.xml b/addons/activeblue_ai/security/res_groups.xml
index 36e614b..cf3b42e 100644
--- a/addons/activeblue_ai/security/res_groups.xml
+++ b/addons/activeblue_ai/security/res_groups.xml
@@ -16,7 +16,7 @@
         <record id="group_ai_manager" model="res.groups">
             <field name="name">AI Manager</field>
             <field name="category_id" ref="module_activeblue_ai"/>
-            <field name="implied_ids" eval="[(4, ref('group_ai_user'))]"/>
+            <field name="implied_ids" eval="[(4, ref('activeblue_ai.group_ai_user'))]"/>
             <field name="users" eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"/>
             <field name="comment">Can configure AI, approve directives, and view all logs</field>
         </record>
diff --git a/addons/activeblue_ai/views/menus.xml b/addons/activeblue_ai/views/menus.xml
index ad983d5..88a3a3e 100644
--- a/addons/activeblue_ai/views/menus.xml
+++ b/addons/activeblue_ai/views/menus.xml
@@ -3,7 +3,6 @@
     <menuitem id="menu_activeblue_ai_root"
               name="ActiveBlue AI"
               sequence="99"
-              web_icon="activeblue_ai,static/src/img/icon.png"
               groups="activeblue_ai.group_ai_user"/>
 
     <menuitem id="menu_ai_directives"