tocmo0nlord/Odoo-18.0-20251222
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] account_financial_report: Filter correctly by account_type in General ledger

Browse Source 
In v15 it was filtered by the internal_type field (type of account.account.type) to use
"other" (most of the accounts had it set). Now in v16, there is the account_type field
exists and has to be compatible. The in or not in operator is set to "simplify" the
domain and avoid having to set almost all types.
This commit is contained in:
Víctor Martínez
2024-03-19 09:40:18 +01:00
committed by chaule97
parent e00e8f8312
commit 0a4dd5df6c
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
account_financial_report/report/general_ledger.py
View File

@@ -50,18 +50,19 @@ class GeneralLedgerReport(models.AbstractModel):
)
return taxes_data
def _get_account_internal_types(self, grouped_by):
return (
["asset_receivable", "liability_payable"]
if grouped_by != "taxes"
else ["other"]
)
def _get_account_type_domain(self, grouped_by):
"""To avoid set all possible types, set in or not in as operator of the types
we are interested in. In v15 we used the internal_type field (type of
account.account.type)."""
at_op = "in" if grouped_by != "taxes" else "not in"
return [
("account_type", at_op, ["asset_receivable", "liability_payable"]),
]
def _get_acc_prt_accounts_ids(self, company_id, grouped_by):
accounts_domain = [
("company_id", "=", company_id),
("account_type", "in", self._get_account_internal_types(grouped_by)),
]
] + self._get_account_type_domain(grouped_by)
acc_prt_accounts = self.env["account.account"].search(accounts_domain)
return acc_prt_accounts.ids
@@ -80,8 +81,7 @@ class GeneralLedgerReport(models.AbstractModel):
accounts = self.env["account.account"].search(accounts_domain)
domain += [("account_id", "in", accounts.ids)]
if acc_prt:
internal_types = self._get_account_internal_types(grouped_by)
domain += [("account_type", "in", internal_types)]
domain += self._get_account_type_domain(grouped_by)
return domain
def _get_initial_balances_pl_ml_domain(