Workaround to unblock docs build in main (#3055)
Co-authored-by: Salman Mohammadi <salman.mohammadi@outlook.com>
This commit is contained in:
10
TODO.md
10
TODO.md
@@ -1,10 +0,0 @@
|
|||||||
# todo list
|
|
||||||
|
|
||||||
- [] Validation of parameters for combinations that won't work
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
## things that are known not to work
|
|
||||||
|
|
||||||
- FSDP offload and gradient_checkpointing - https://github.com/pytorch/pytorch/issues/82203
|
|
||||||
- adamw_bnb_8bit doesn't play well with FSDP offload
|
|
||||||
@@ -67,14 +67,12 @@ def build_command(base_cmd: list[str], options: dict[str, Any]) -> list[str]:
|
|||||||
|
|
||||||
def generate_config_files(config: str, sweep: str | None) -> Iterator[tuple[str, bool]]:
|
def generate_config_files(config: str, sweep: str | None) -> Iterator[tuple[str, bool]]:
|
||||||
"""
|
"""
|
||||||
Generate list of configuration files to process.
|
Generate list of configuration files to process. Yields a tuple of the configuration file name and a boolean indicating
|
||||||
|
whether this is a group of configurations (i.e., a sweep).
|
||||||
|
|
||||||
Args:
|
Args:
|
||||||
config: Base configuration file
|
config: Base configuration file
|
||||||
sweep: Sweep configuration file
|
sweep: Sweep configuration file
|
||||||
|
|
||||||
Yields:
|
|
||||||
Tuple of configuration file name and whether this is a group of configurations
|
|
||||||
"""
|
"""
|
||||||
|
|
||||||
if not sweep:
|
if not sweep:
|
||||||
|
|||||||
Reference in New Issue
Block a user