tocmo0nlord/duplicate-finder
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix 'failed to load group' on click

Browse Source 
The detail-panel insertion logic mixed parent contexts: it called
grid.parentNode.insertBefore() but used a child-of-grid as the reference
node. insertBefore requires the reference node to be a child of the
target parent — it threw 'node is not a child of this node' on every
click.

Replaced the inter-row positioning with simple insert-after-grid. Same
visual outcome since panel.scrollIntoView() handles user focus.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Carlos
2026-04-26 18:29:32 -04:00
parent 759288b37e
commit 3128ddc593
2 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
debian/build-deb.sh vendored
View File

@@ -13,7 +13,7 @@ BUILD_DIR="$REPO_ROOT/build/deb"
# ── Config ────────────────────────────────────────────────────────────────────
PKG_NAME="dupfinder"
PKG_VERSION="1.0.9"
PKG_VERSION="1.0.10"
PKG_ARCH="amd64"
DEB_FILE="${PKG_NAME}_${PKG_VERSION}_${PKG_ARCH}.deb"

16
templates/index.html
View File

@@ -1288,19 +1288,13 @@ async function openGroup(groupId, cellEl) {
state.activeGroupData = g;
renderDetail(g);
// Insert detail panel after the row containing the clicked cell
// Position detail panel directly after the grid (in the grid's parent).
// Earlier we tried to thread it between grid rows but mixed parent
// contexts and threw "node is not a child of this node".
const panel = el('detail-panel');
const grid = el('gallery-grid');
if (cellEl) {
// find row end
const cellRect = cellEl.getBoundingClientRect();
const gridRect = grid.getBoundingClientRect();
const cells = Array.from(grid.children).filter(c => c.classList.contains('gallery-cell'));
const cols = Math.round(grid.offsetWidth / (cellEl.offsetWidth + 12));
const cellIdx = cells.indexOf(cellEl);
const rowEnd = Math.min(Math.ceil((cellIdx + 1) / cols) * cols, cells.length);
const afterCell = cells[rowEnd - 1];
grid.parentNode.insertBefore(panel, afterCell.nextSibling || el('load-more-wrap'));
if (panel.parentNode !== grid.parentNode || panel.previousSibling !== grid) {
grid.parentNode.insertBefore(panel, grid.nextSibling);
}
panel.classList.add('show');
panel.scrollIntoView({ behavior: 'smooth', block: 'nearest' });